Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX - Document mocked Span::start and Span::end methods #268

Merged
merged 1 commit into from
Nov 23, 2020
Merged

FIX - Document mocked Span::start and Span::end methods #268

merged 1 commit into from
Nov 23, 2020

Conversation

Elrendio
Copy link
Contributor

@Elrendio Elrendio commented Nov 10, 2020 •
edited
Loading

Helps #237

What it does:

  • Adds warning on methods Span::start and Span::end methods

FIX - Document mocked Span::start and Span::end methods
702c248 
Helps dtolnay#237

**What it does:**
 - Adds warning on methods `Span::start` and `Span::end` methods
@Elrendio Elrendio force-pushed the FIX-document_mock_span_start_and_end_methods branch from 6640c8a to 702c248 Compare November 10, 2020 20:43
@Elrendio
Copy link
Contributor Author

Hello @alexcrichton ,

Would you have time to look at this ?

Thanks,

Elrendio

@alexcrichton
Copy link
Contributor

Ah yes looks good to me, thanks!

@alexcrichton alexcrichton merged commit 3c856d2 into dtolnay:master Nov 23, 2020
@dtolnay dtolnay mentioned this pull request Mar 30, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Elrendio @alexcrichton